Update kinetis pinctrl script for pin mask #582
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Pinctrl generation script to use the source xml files into finding the pin_mux mask variable. Changed from hard coding this part of the generated macro to using this new mask variable.
mmahadevan108
requested review from
danieldegrasse,
mmahadevan108,
decsny and
dleach02
| macro_mask = pin_mux_opt[pin_mux_opt_name]._mask | ||
| macro_mask_after_bitshift = f"0x{int(macro_mask, 0) >> 8:X}" | ||
|
|
||
| mux_macro += "\t(((mux) & " + str(macro_mask_after_bitshift) + ") << 8))\n\n" |
There was a problem hiding this comment.
No need to force to str() here, the f-string above will already do that
There was a problem hiding this comment.
Are these changes intended to support V14 of the config tools file format? That is what the scripts are documented to support right now: https://github.com/zephyrproject-rtos/hal_nxp/tree/master/mcux/scripts/pinctrl#requirements. If the update is being made because the format has changed, it would be good to update the version of the file format we know the scripts work with (since I'm assuming you just tested them with this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Pinctrl generation script to use the source xml files into finding the pin_mux mask variable. Changed from hard coding this part of the generated macro to using this new mask variable.